[Mesa-dev] [PATCH 3/3 v2] glx/dri2: Add support for GLX_ARB_create_context_robustness

[Eric Anholt]

Ian Romanick <idr at freedesktop.org> writes:
> From: Ian Romanick <ian.d.romanick at intel.com>

> @@ -979,6 +990,11 @@ dri2BindExtensions(struct dri2_screen *psc, const __DRIextension **extensions)
>  
>        if (((strcmp(extensions[i]->name, __DRI2_THROTTLE) == 0)))
>  	 psc->throttle = (__DRI2throttleExtension *) extensions[i];
> +
> +      if (psc->dri2->base.version >= 3
> +          && strcmp(extensions[i]->name, __DRI2_ROBUSTNESS) == 0)
> +         __glXEnableDirectExtension(&psc->base,
> +                                    "GLX_ARB_create_context_robustness");
>     }
>  }

I think you want to drop the base.version check here.

>  #endif /* _DRI_COMMON_H */
> diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c
> index 95d2dcc..519786e 100644
> --- a/src/glx/drisw_glx.c
> +++ b/src/glx/drisw_glx.c
> @@ -433,6 +433,7 @@ drisw_create_context_attribs(struct glx_screen *base,
>     uint32_t major_ver = 0;
>     uint32_t flags = 0;
>     unsigned api;
> +   int reset;
>     uint32_t ctx_attribs[2 * 4];

Does this one need to get bumped to 2 * 5 too?

Other than that,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120711/bd375221/attachment.pgp>