[Mesa-dev] [PATCH 1/3] glapi: Apply Xorg indent rules to all files generated for the xserver

Kenneth Graunke kenneth at whitecape.org
Tue Jul 3 15:09:17 PDT 2012


On 07/03/2012 12:57 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/mapi/glapi/gen/Makefile.am |   54 ++++++++++++++++++++++++++++-----------
>  1 files changed, 39 insertions(+), 15 deletions(-)

This series looks good to me, but it would probably be best to have
someone more familiar with the code in patch 3 review that.

I was going to comment that XORG_INDENT_RULES should be "" when INDENT
== cat (GNU indent isn't installed), but since files are being committed
to the X server, you really want them indented properly.

For the series:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list