[Mesa-dev] [PATCH 10/10] i965/msaa: Remove comment about falsely claiming to support MSAA.

[Chad Versace]

On 07/24/2012 10:39 AM, Paul Berry wrote:
> On 24 July 2012 10:15, Chad Versace <chad.versace at linux.intel.com
> <mailto:chad.versace at linux.intel.com>> wrote:
> 
>     On 07/18/2012 08:15 AM, Paul Berry wrote:
>     > Gen6+ hardware now supports MSAA properly.
>     > ---
>     >  src/mesa/drivers/dri/i965/brw_context.c |    5 -----
>     >  1 files changed, 0 insertions(+), 5 deletions(-)
>     >
>     > diff --git a/src/mesa/drivers/dri/i965/brw_context.c
>     b/src/mesa/drivers/dri/i965/brw_context.c
>     > index f5c8b6e..9917741 100644
>     > --- a/src/mesa/drivers/dri/i965/brw_context.c
>     > +++ b/src/mesa/drivers/dri/i965/brw_context.c
>     > @@ -154,11 +154,6 @@ brwCreateContext(int api,
>     >     ctx->Const.MaxTransformFeedbackSeparateComponents =
>     >        BRW_MAX_SOL_BINDINGS / BRW_MAX_SOL_BUFFERS;
>     >
>     > -   /* Claim to support 4 multisamples, even though we don't.  This is a
>     > -    * requirement for GL 3.0 that we missed until the last minute.  Go
>     ahead and
>     > -    * claim the limit, so that usage of the 4 multisample-based API that is
>     > -    * guaranteed in 3.0 succeeds, even though we only rasterize a single
>     sample.
>     > -    */
>     >     if (intel->gen >= 6)
>     >        ctx->Const.MaxSamples = 4;
>     >
> 
>     I wonder how prevalent are such stale comments in our driver...
> 
>     Reviewed-by: Chad Versace <chad.versace at linux.intel.com
>     <mailto:chad.versace at linux.intel.com>
> 
> 
> Thanks for all the review, Chad.  Were you planning on reviewing patch 4/10 as
> well?  It looks like that one got skipped.

I overlooked it and am returning to it now.