[Mesa-dev] [PATCH] automake: Honor (GL|GLU|OSMESA)_LIB from environment

[Brad King]

On 06/01/2012 05:49 PM, Dan Nicholson wrote:
>> +AC_ARG_VAR([GL_LIB],[name of GL library @<:@default=GL@:>@])
>> +AC_ARG_VAR([GLU_LIB],[name of GLU library @<:@default=GLU@:>@])
>> +AC_ARG_VAR([OSMESA_LIB],[name of OSMesa library @<:@default=OSMesa@:>@])
>> +GL_LIB="${GL_LIB-GL}"
>> +GLU_LIB="${GLU_LIB-GLU}"
>> +OSMESA_LIB="${OSMESA_LIB-OSMesa}"
> 
> I don't think this part is necessary. AC_ARG_VAR does this already. The rest makes sense though.

Thanks for taking a look.  I think the init lines are needed in
order to set the default values.  With the patch below on top of
this one I get output

 GL_LIB=
 GLU_LIB=
 OSMESA_LIB=

and the build fails.  I see no mention in AC_ARG_VAR documentation
about default value selection:

 http://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Setting-Output-Variables.html#index-AC_005fARG_005fVAR-1134

-Brad


diff --git a/configure.ac b/configure.ac
index 7f6ba96..b4c0a4a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -358,9 +358,9 @@ fi
 AC_ARG_VAR([GL_LIB],[name of GL library @<:@default=GL@:>@])
 AC_ARG_VAR([GLU_LIB],[name of GLU library @<:@default=GLU@:>@])
 AC_ARG_VAR([OSMESA_LIB],[name of OSMesa library @<:@default=OSMesa@:>@])
-GL_LIB="${GL_LIB-GL}"
-GLU_LIB="${GLU_LIB-GLU}"
-OSMESA_LIB="${OSMESA_LIB-OSMesa}"
+echo "GL_LIB=[$GL_LIB]"
+echo "GLU_LIB=[$GLU_LIB]"
+echo "OSMESA_LIB=[$OSMESA_LIB]"

 dnl
 dnl Mangled Mesa support