[Mesa-dev] [PATCH] automake: Honor (GL|GLU|OSMESA)_LIB from environment

Dan Nicholson dbn.lists at gmail.com
Tue Jun 5 08:12:28 PDT 2012


On 6/4/12, Brad King <brad.king at kitware.com> wrote:
> On 06/01/2012 05:49 PM, Dan Nicholson wrote:
>>> +AC_ARG_VAR([GL_LIB],[name of GL library @<:@default=GL@:>@])
>>> +AC_ARG_VAR([GLU_LIB],[name of GLU library @<:@default=GLU@:>@])
>>> +AC_ARG_VAR([OSMESA_LIB],[name of OSMesa library
>>> @<:@default=OSMesa@:>@])
>>> +GL_LIB="${GL_LIB-GL}"
>>> +GLU_LIB="${GLU_LIB-GLU}"
>>> +OSMESA_LIB="${OSMESA_LIB-OSMesa}"
>>
>> I don't think this part is necessary. AC_ARG_VAR does this already. The
>> rest makes sense though.
>
> Thanks for taking a look.  I think the init lines are needed in
> order to set the default values.  With the patch below on top of
> this one I get output
>
>  GL_LIB=
>  GLU_LIB=
>  OSMESA_LIB=
>
> and the build fails.  I see no mention in AC_ARG_VAR documentation
> about default value selection:
>
> http://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Setting-Output-Variables.html#index-AC_005fARG_005fVAR-1134

Duh, you're right. I think this original patch is good to go. The
variables should be substituted in configs/autoconf and a quick grep
shows that there are no remaining hardcoded -lGL around (I think).

--
Dan


More information about the mesa-dev mailing list