[Mesa-dev] [PATCH 2/4] i965/blorp: De-virtualize brw_blorp_{mip, surface}_info::set() function.

Paul Berry stereotype441 at gmail.com
Wed Jun 6 21:20:31 CEST 2012


Even though brw_blorp_surface_info is derived from brw_blorp_mip_info,
this function doesn't need to be virtual, because it is never accessed
through a base class pointer.  Making the function non-virtual will
allow it to take additional parameters in the brw_blorp_surface_info
case.
---
 src/mesa/drivers/dri/i965/brw_blorp.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_blorp.h b/src/mesa/drivers/dri/i965/brw_blorp.h
index bff7715..0de3d1e 100644
--- a/src/mesa/drivers/dri/i965/brw_blorp.h
+++ b/src/mesa/drivers/dri/i965/brw_blorp.h
@@ -46,8 +46,8 @@ class brw_blorp_mip_info
 public:
    brw_blorp_mip_info();
 
-   virtual void set(struct intel_mipmap_tree *mt,
-                    unsigned int level, unsigned int layer);
+   void set(struct intel_mipmap_tree *mt,
+            unsigned int level, unsigned int layer);
    void get_draw_offsets(uint32_t *draw_x, uint32_t *draw_y) const;
 
    void get_miplevel_dims(uint32_t *width, uint32_t *height) const
@@ -66,8 +66,8 @@ class brw_blorp_surface_info : public brw_blorp_mip_info
 public:
    brw_blorp_surface_info();
 
-   virtual void set(struct intel_mipmap_tree *mt,
-                    unsigned int level, unsigned int layer);
+   void set(struct intel_mipmap_tree *mt,
+            unsigned int level, unsigned int layer);
 
    /* Setting this flag indicates that the buffer's contents are W-tiled
     * stencil data, but the surface state should be set up for Y tiled
-- 
1.7.7.6



More information about the mesa-dev mailing list