[Mesa-dev] [PATCH 04/19] make: Drop HOST_CC and HOST_CFLAGS.

[Matt Turner]

On Wed, Jun 13, 2012 at 4:52 PM, Jakob Bornecrantz <jakob at vmware.com> wrote:
> ----- Original Message -----
>> Except for the deleted linux-cell target, these were just the target
>> cc/cflags.  The only usage was for gen_matypes, which wants the
>> target's structure packing, not the host, anyway.
>> ---
>>  configs/default       |    2 --
>>  src/mesa/x86/Makefile |    2 +-
>>  2 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/configs/default b/configs/default
>> index 20ba796..bf67d34 100644
>> --- a/configs/default
>> +++ b/configs/default
>> @@ -19,11 +19,9 @@ DRM_SOURCE_PATH=$(TOP)/../drm
>>  # Compiler and flags
>>  CC = cc
>>  CXX = CC
>> -HOST_CC = $(CC)
>>  CFLAGS = -O
>>  CXXFLAGS = -O
>>  LDFLAGS =
>> -HOST_CFLAGS = $(CFLAGS)
>>  GLU_CFLAGS =
>>  GLX_TLS = no
>>
>> diff --git a/src/mesa/x86/Makefile b/src/mesa/x86/Makefile
>> index 9716dc2..8107176 100644
>> --- a/src/mesa/x86/Makefile
>> +++ b/src/mesa/x86/Makefile
>> @@ -21,7 +21,7 @@ clean:
>>
>>
>>  gen_matypes: gen_matypes.c
>> -     $(HOST_CC) $(ARCH_FLAGS) $(INCLUDE_DIRS) $(HOST_CFLAGS) gen_matypes.c -o gen_matypes
>> +     $(CC) $(ARCH_FLAGS) $(INCLUDE_DIRS) $(CFLAGS) gen_matypes.c -o gen_matypes
>
> Wont this explode in a great ball of fire if somebody is doing 32
> to 64bit cross compiles? While that might not be the most common
> case shouldn't gen_matypes be safe for 64 to 32bit builds?
>
> Do we still run the glslcompiler on builds as well? Doesn't it
> need HOST_CC?

It's already broken, see https://bugs.freedesktop.org/show_bug.cgi?id=44618

Would be nice to get fixed, but that's probably something that should
come after automake.