[Mesa-dev] [PATCH] mesa: Fix an issue with texture border in strip_texture_border()

Brian Paul brianp at vmware.com
Mon Mar 5 15:47:26 PST 2012


On 03/01/2012 03:37 PM, Anuj Phogat wrote:
> Border only applies to the width for a 1D texture array and for 2D
> texture array it applies to the width and height but not to the
> depth.  This was not handled correctly in strip_texture_border().
>
> v2: height is also affected by border if target is GL_TEXTURE_3D
> v3: simplified the logic to strip texture dimensions:
>      As the legal_teximage_target() is called earlier in teximage()
>      function, we don't need to repeat that here. Also assuming that
>      strip_texture_border() will not be used for proxy textures
>      otherwise we have to include proxy targets as well.
>
> Note: This is a candidate for stable branches
>
> Signed-off-by: Anuj Phogat<anuj.phogat at gmail.com>

Did you see the version that I posted?  I think it was a little 
cleaner than your patch.  What do you think?

-Brian



More information about the mesa-dev mailing list