[Mesa-dev] [PATCH 1/2] mesa: set numFaces=6 for cube maps in _mesa_test_texobj_completeness()

Brian Paul brianp at vmware.com
Fri Mar 23 07:22:39 PDT 2012


On 03/23/2012 08:21 AM, Jakob Bornecrantz wrote:
> ----- Original Message -----
>> ---
>>   src/mesa/main/texobj.c |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c
>> index cfaac64..97bef35 100644
>> --- a/src/mesa/main/texobj.c
>> +++ b/src/mesa/main/texobj.c
>> @@ -567,7 +567,8 @@ _mesa_test_texobj_completeness( const struct
>> gl_context *ctx,
>>         GLint i;
>>         const GLint minLevel = baseLevel;
>>         const GLint maxLevel = t->_MaxLevel;
>> -      GLuint width, height, depth, face, numFaces = 1;
>> +      const GLuint numFaces = t->Target == GL_TEXTURE_CUBE_MAP ? 6 : 1;
>> +      GLuint width, height, depth, face;
>>
>>         if (minLevel>  maxLevel) {
>>            incomplete(t, BASE, "minLevel>  maxLevel");
>
> Looks good, shouldn't this be applied to 8.0?

No, the rewritten _mesa_test_texobj_completeness() function is only in 
master.

-Brian


More information about the mesa-dev mailing list