[Mesa-dev] [PATCH 1/2] mesa: set numFaces=6 for cube maps in _mesa_test_texobj_completeness()

Jakob Bornecrantz jakob at vmware.com
Fri Mar 23 07:21:40 PDT 2012


----- Original Message -----
> ---
>  src/mesa/main/texobj.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c
> index cfaac64..97bef35 100644
> --- a/src/mesa/main/texobj.c
> +++ b/src/mesa/main/texobj.c
> @@ -567,7 +567,8 @@ _mesa_test_texobj_completeness( const struct
> gl_context *ctx,
>        GLint i;
>        const GLint minLevel = baseLevel;
>        const GLint maxLevel = t->_MaxLevel;
> -      GLuint width, height, depth, face, numFaces = 1;
> +      const GLuint numFaces = t->Target == GL_TEXTURE_CUBE_MAP ? 6 : 1;
> +      GLuint width, height, depth, face;
>  
>        if (minLevel > maxLevel) {
>           incomplete(t, BASE, "minLevel > maxLevel");

Looks good, shouldn't this be applied to 8.0?

Cheers, Jakob.


More information about the mesa-dev mailing list