[Mesa-dev] [PATCH] mesa: fix Z32_FLOAT -> uint conversion functions

Jose Fonseca jfonseca at vmware.com
Sat May 19 02:38:47 PDT 2012


Looks good.

Jose

----- Original Message -----
> The IROUND converted all arguments to 0 or 1.  That's not what we
> wanted.
> 
> NOTE: This is a candidate for the 8.0 branch.
> ---
>  src/mesa/main/format_unpack.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/main/format_unpack.c
> b/src/mesa/main/format_unpack.c
> index b00e012..c42bac1 100644
> --- a/src/mesa/main/format_unpack.c
> +++ b/src/mesa/main/format_unpack.c
> @@ -2929,7 +2929,7 @@ unpack_uint_z_Z32_FLOAT(const void *src, GLuint
> *dst, GLuint n)
>     const float *s = (const float *)src;
>     GLuint i;
>     for (i = 0; i < n; i++) {
> -      dst[i] = FLOAT_TO_UINT(IROUND(CLAMP((s[i]), 0.0F, 1.0F)));
> +      dst[i] = FLOAT_TO_UINT(CLAMP(s[i], 0.0F, 1.0F));
>     }
>  }
>  
> @@ -2940,7 +2940,7 @@ unpack_uint_z_Z32_FLOAT_X24S8(const void *src,
> GLuint *dst, GLuint n)
>     GLuint i;
>  
>     for (i = 0; i < n; i++) {
> -      dst[i] = FLOAT_TO_UINT(IROUND(CLAMP((s[i].z), 0.0F, 1.0F)));
> +      dst[i] = FLOAT_TO_UINT(CLAMP(s[i].z, 0.0F, 1.0F));
>     }
>  }
>  
> --
> 1.7.3.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 


More information about the mesa-dev mailing list