[Mesa-dev] [PATCH] intel: Change vendor string to "Intel(R) Open Source Technology Center".

[Roland Mainz]

On Fri, Jun 1, 2012 at 1:34 AM, Alan Coopersmith
<alan.coopersmith at oracle.com> wrote:
> On 05/31/12 04:28 PM, Roland Mainz wrote:
>> On Fri, Jun 1, 2012 at 1:19 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>>>    switch (name) {
>>>    case GL_VENDOR:
>>> -      return (GLubyte *) "Tungsten Graphics, Inc";
>>> +      return (GLubyte *) "Intel® Open Source Technology Center";
>>>       break;
>>
>> Uhm... isn't "®" a character outside the ASCII range ? Some compiles
>> might choke on this, i.e. the Sun Workshop/Forte/Studio compilers
>> require -xcsi ("... This option allows the C compiler to accept source
>> code written in locales that do not conform to the ISO C source
>> character code requirements. These locales include ja_JP.PCK ...") to
>> avoid occasional hiccups.
>
> I don't remember having any problems with the Studio compilers using UTF-8
> characters,

Technically they shouldn't... but I still remember being chased around
(oh... yes... I lively remember *THAT* ... *shudder* ... the teeth...
these horrible t...[1]) by Sun's ON gatekeeper for causing the
occasional one in 100 random build failures until we figured out that
we need to add -xcsi (see
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/Makefile.ast#73).

[1]=Yes, yes... I'm joking a bit... :-)

> but they do break down if you use other encodings that appear
> to cause invalid UTF-8 sequences.

s/invalid UTF-8 sequence/invalid multibyte sequences/

The code works as long you either use the "C", "POSIX" or an
UTF-8-based locale but any other encoding scheme (like GB18030) will
likely cause a build failure.

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 3992797
 (;O/ \/ \O;)