[Mesa-dev] [PATCH] intel: Change vendor string to "Intel(R) Open Source Technology Center".

[Kenneth Graunke]

On 05/31/2012 04:28 PM, Roland Mainz wrote:
> On Fri, Jun 1, 2012 at 1:19 AM, Kenneth Graunke<kenneth at whitecape.org>  wrote:
>> Tungsten Graphics has not existed for several years, and the majority of
>> ongoing development and support is done by Intel.  I chose to include
>> "Open Source Technology Center" to distinguish it from, say, the closed
>> source Windows OpenGL driver.
>>
>> The one downside to this patch is that applications that pattern match
>> against "Intel" may start applying workarounds meant for the Windows
>> driver.  However, it does seem like the right thing to do.
>>
>> This does change oglconform behavior.
>>
>> Acked-by: Eric Anholt<eric at anholt.net>
>> Acked-by: Ian Romanick<ian.d.romanick at intel.com>
>> Cc: Eugeni Dodonov<eugeni at dodonov.net>
>> Signed-off-by: Kenneth Graunke<kenneth at whitecape.org>
>> ---
>>   src/mesa/drivers/dri/intel/intel_context.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
>> index 9deb4ca..712acb8 100644
>> --- a/src/mesa/drivers/dri/intel/intel_context.c
>> +++ b/src/mesa/drivers/dri/intel/intel_context.c
>> @@ -72,7 +72,7 @@ intelGetString(struct gl_context * ctx, GLenum name)
>>
>>     switch (name) {
>>     case GL_VENDOR:
>> -      return (GLubyte *) "Tungsten Graphics, Inc";
>> +      return (GLubyte *) "Intel® Open Source Technology Center";
>>        break;
>
> Uhm... isn't "®" a character outside the ASCII range ? Some compiles
> might choke on this, i.e. the Sun Workshop/Forte/Studio compilers
> require -xcsi ("... This option allows the C compiler to accept source
> code written in locales that do not conform to the ISO C source
> character code requirements. These locales include ja_JP.PCK ...") to
> avoid occasional hiccups.

I'm happy to change it if it's an issue, but I believe that the ® 
character already appears in the source code:

       case PCI_CHIP_GM45_GM:
          chipset = "Mobile Intel® GM45 Express Chipset";
          break;

and it definitely appears in comments.