[Mesa-dev] [PATCH] arb_texture_cube_map_array: fix attrib push/pop

Dave Airlie airlied at gmail.com
Wed Nov 7 12:51:05 PST 2012


On Thu, Nov 8, 2012 at 1:00 AM, Brian Paul <brianp at vmware.com> wrote:
> On 11/06/2012 07:56 PM, Dave Airlie wrote:
>>
>> From: Dave Airlie<airlied at redhat.com>
>>
>> fdo9833 piglit test caught this.
>
>
> What exactly was the failure?

The pop attrib was failing with an error, probably due to the missing
continue from below,

but you are right about the push attrib bit being unneceessary since
there is no ff bits for cube map arrays.

For the second hunk I probably should just continue no matter what.

Dave.


More information about the mesa-dev mailing list