[Mesa-dev] [PATCH] arb_texture_cube_map_array: fix attrib push/pop

[Brian Paul]

On 11/07/2012 01:51 PM, Dave Airlie wrote:
> On Thu, Nov 8, 2012 at 1:00 AM, Brian Paul<brianp at vmware.com>  wrote:
>> On 11/06/2012 07:56 PM, Dave Airlie wrote:
>>>
>>> From: Dave Airlie<airlied at redhat.com>
>>>
>>> fdo9833 piglit test caught this.
>>
>>
>> What exactly was the failure?
>
> The pop attrib was failing with an error, probably due to the missing
> continue from below,
>
> but you are right about the push attrib bit being unneceessary since
> there is no ff bits for cube map arrays.
>
> For the second hunk I probably should just continue no matter what.

You mean skip the extension check?  I don't think so.  The cube array 
object's texture parameters should saved/restored like any other 
texture target.

-Brian