[Mesa-dev] [PATCH 1/6] mesa: add MaxNumLevels to gl_texture_image, remove MaxLog2

[Marek Olšák]

AFAIK, r600g has been immune to some of these bugs. You can set
last_level to any large value and it will just work. Christoph B. told
me he had had a problem with last_level being too large and I decided
to review all the other related places in mesa/main and st/mesa and
came up with this series just by reading the code.

Making a test for the TexStorage error checking would be really
simple. Making a test that validates if the array size isn't magnified
in guess_base_level_size would also be possible. I think the other
bugs fixed here are not reproducible on r600g. I'm not so sure about
the other drivers.

Marek

On Mon, Nov 12, 2012 at 12:06 AM, Dave Airlie <airlied at gmail.com> wrote:
>> MaxLog2 led to bugs, because it didn't work well with 1D and 3D textures.
>
> They all look good to me, but I suppose Brian might want to check them over,
>
> Any ideas for a piglit test to show any of this or is it mostly just
> internal bugs at the driver interfaces?
>
> Reviewed-by: Dave Airlie <airlied at redhat.com>
> Dave.