[Mesa-dev] [PATCH] gallium: Some function headers comment fixes in p_context.h

Brian Paul brianp at vmware.com
Thu Nov 15 06:53:02 PST 2012


On 11/14/2012 12:33 PM, Dmitry Cherkassov wrote:
> Signed-off-by: Dmitry Cherkassov<dcherkassov at gmail.com>
> ---
>   src/gallium/include/pipe/p_context.h |    5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h
> index 88e12b2..c5dcae5 100644
> --- a/src/gallium/include/pipe/p_context.h
> +++ b/src/gallium/include/pipe/p_context.h
> @@ -230,21 +230,21 @@ struct pipe_context {
>
>      void (*set_compute_sampler_views)(struct pipe_context *,
>                                        unsigned start_slot, unsigned num_views,
>                                        struct pipe_sampler_view **);
>
>      /**
>       * Bind an array of shader resources that will be used by the
>       * graphics pipeline.  Any resources that were previously bound to
>       * the specified range will be unbound after this call.
>       *
> -    * \param first      first resource to bind.
> +    * \param start      first resource to bind.
>       * \param count      number of consecutive resources to bind.
>       * \param resources  array of pointers to the resources to bind, it
>       *                   should contain at least \a count elements
>       *                   unless it's NULL, in which case no new
>       *                   resources will be bound.
>       */
>      void (*set_shader_resources)(struct pipe_context *,
>                                   unsigned start, unsigned count,
>                                   struct pipe_surface **resources);
>
> @@ -359,21 +359,20 @@ struct pipe_context {
>                                                        struct pipe_resource *texture,
>                                                        const struct pipe_sampler_view *templat);
>
>      void (*sampler_view_destroy)(struct pipe_context *ctx,
>                                   struct pipe_sampler_view *view);
>
>
>      /**
>       * Get a surface which is a "view" into a resource, used by
>       * render target / depth stencil stages.
> -    * \param usage  bitmaks of PIPE_BIND_* flags
>       */
>      struct pipe_surface *(*create_surface)(struct pipe_context *ctx,
>                                             struct pipe_resource *resource,
>                                             const struct pipe_surface *templat);
>
>      void (*surface_destroy)(struct pipe_context *ctx,
>                              struct pipe_surface *);
>
>      /**
>       * Map a resource.
> @@ -447,21 +446,21 @@ struct pipe_context {
>      void *(*create_compute_state)(struct pipe_context *context,
>   				 const struct pipe_compute_state *);
>      void (*bind_compute_state)(struct pipe_context *, void *);
>      void (*delete_compute_state)(struct pipe_context *, void *);
>
>      /**
>       * Bind an array of shader resources that will be used by the
>       * compute program.  Any resources that were previously bound to
>       * the specified range will be unbound after this call.
>       *
> -    * \param first      first resource to bind.
> +    * \param start      first resource to bind.
>       * \param count      number of consecutive resources to bind.
>       * \param resources  array of pointers to the resources to bind, it
>       *                   should contain at least \a count elements
>       *                   unless it's NULL, in which case no new
>       *                   resources will be bound.
>       */
>      void (*set_compute_resources)(struct pipe_context *,
>                                    unsigned start, unsigned count,
>                                    struct pipe_surface **resources);
>


Reviewed-by: Brian Paul <brianp at vmware.com>

I'll commit this for you.

-Brian


More information about the mesa-dev mailing list