[Mesa-dev] [PATCH v3 4/7] mesa dispatch_sanity: call new functions to initialize exec table

Ian Romanick idr at freedesktop.org
Wed Nov 21 10:12:20 PST 2012


On 11/19/2012 05:01 PM, Jordan Justen wrote:
> In a future patch the exec functions will no longer set up
> by _mesa_initialize_context and _vbo_CreateContext.
>
> Therefore we must call _mesa_initialize_exec_table and
> _mesa_initialize_exec_table_vbo.
>
> v3:
>   * Initialize VBO functions with _mesa_initialize_exec_table_vbo

Are these changes necessary to make the test pass after previous 
changes?  If so, this should get squashed with the patch that changes 
the interfaces.  There's shouldn't be any commit where 'make check' 
breaks.  Bisecting is very irritating otherwise.

> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>   src/mesa/main/tests/dispatch_sanity.cpp |    7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
> index 56f0dfb..d61d6de 100644
> --- a/src/mesa/main/tests/dispatch_sanity.cpp
> +++ b/src/mesa/main/tests/dispatch_sanity.cpp
> @@ -52,6 +52,7 @@ extern "C" {
>   #include "main/api_exec.h"
>   #include "main/context.h"
>   #include "main/remap.h"
> +#include "main/vtxfmt.h"
>   #include "glapi/glapi.h"
>   #include "drivers/common/driverfuncs.h"
>
> @@ -103,13 +104,17 @@ DispatchSanity_test::SetUp()
>   void
>   DispatchSanity_test::SetUpCtx(gl_api api, unsigned int version)
>   {
> -   ctx.Version = version;
>      _mesa_initialize_context(&ctx,
>                               api,
>                               &visual,
>                               NULL, // share_list
>                               &driver_functions);
>      _vbo_CreateContext(&ctx);
> +
> +   ctx.Version = version;
> +
> +   _mesa_initialize_exec_table(&ctx);
> +   _mesa_initialize_vbo_vtxfmt(&ctx);
>   }
>
>   static const char *
>



More information about the mesa-dev mailing list