[Mesa-dev] [PATCH v3 4/7] mesa dispatch_sanity: call new functions to initialize exec table

Jordan Justen jljusten at gmail.com
Wed Nov 21 10:44:37 PST 2012


On Wed, Nov 21, 2012 at 10:12 AM, Ian Romanick <idr at freedesktop.org> wrote:
> On 11/19/2012 05:01 PM, Jordan Justen wrote:
>>
>> In a future patch the exec functions will no longer set up
>> by _mesa_initialize_context and _vbo_CreateContext.
>>
>> Therefore we must call _mesa_initialize_exec_table and
>> _mesa_initialize_exec_table_vbo.
>>
>> v3:
>>   * Initialize VBO functions with _mesa_initialize_exec_table_vbo
>
> Are these changes necessary to make the test pass after previous changes?
> If so, this should get squashed with the patch that changes the interfaces.
> There's shouldn't be any commit where 'make check' breaks.  Bisecting is
> very irritating otherwise.

I definitely tried to create the series with bisect in mind. I think
it should build and function properly at each point, but I didn't
verify each point. I did just verify 'make check' works before this
commit.

There is some duplicate initialization of the dispatch functions near
the middle of the series, but this is removed in patches 5 & 6.

-Jordan


More information about the mesa-dev mailing list