[Mesa-dev] [PATCH 0/5 v2] (gles3) Add plubming for EGL_OPENGL_ES3_BIT

[Ian Romanick]

On 11/21/2012 05:43 PM, Chad Versace wrote:
> Fixes error EGL_BAD_ATTRIBUTE in the tests below on Intel Sandybridge:
>    * piglit egl-create-context-verify-gl-flavor, testcase OpenGL ES 3.0
>    * gles3conform, revision 19700, when GL3Tests are ran with -fbo
>
> The series lives on my es3-bit-v3 branch. It adds a new enum, __DRI_API_GLES3,
> and does the needed plumbing in the EGL and DRI layers and the Intel drivers
> to support EGL_OPENGL_ES3_BIT_KHR. The GLX layer and core mesa are left
> untouched.
>
> I tested the series against gen6 with piglit
> egl-create-context-verify-gl-flavor. I verified that the series, other than
> exposing ES3, does not change the set of exposed EGL context flavors.

Have you tested this on recent GLES3 conform?  Perhaps Matt or someone 
could try that and give a Tested-by.

> v2: Only expose the ES3 bit if the hardware/driver combo is capable of
> creating an ES3 context, as requested by Ian.

Other than my nits on patch 1, this series is:

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> Chad Versace (5):
>    intel: Set screen's api mask according to hw capabilities
>    intel: Move validation of context version into intelInitContext
>    dri: Define enum __DRI_API_GLES3
>    intel: Expose support for DRI_API_GLES3
>    egl/dri2: Add plumbing for EGL_OPENGL_ES3_BIT_KHR
>
>   include/GL/internal/dri_interface.h        |   3 +-
>   src/egl/drivers/dri2/egl_dri2.c            |  11 ++-
>   src/egl/main/eglconfig.c                   |   1 +
>   src/egl/main/eglcontext.c                  |   4 +-
>   src/egl/main/eglcurrent.h                  |   1 +
>   src/egl/main/eglmisc.c                     |   3 +
>   src/egl/main/eglsurface.c                  |   5 +-
>   src/mesa/drivers/dri/common/dri_util.c     |   1 +
>   src/mesa/drivers/dri/common/drisw_util.c   |   1 +
>   src/mesa/drivers/dri/i915/i830_context.c   |  20 +++--
>   src/mesa/drivers/dri/i915/i830_context.h   |   6 +-
>   src/mesa/drivers/dri/i915/i915_context.c   |  32 ++-----
>   src/mesa/drivers/dri/i965/brw_context.c    |  47 ++--------
>   src/mesa/drivers/dri/intel/intel_context.c |  56 +++++++++++-
>   src/mesa/drivers/dri/intel/intel_context.h |  13 +--
>   src/mesa/drivers/dri/intel/intel_screen.c  | 134 +++++++++++++++++++++--------
>   src/mesa/drivers/dri/intel/intel_screen.h  |   5 ++
>   17 files changed, 221 insertions(+), 122 deletions(-)
>