[Mesa-dev] [PATCH 0/5 v2] (gles3) Add plubming for EGL_OPENGL_ES3_BIT

[Chad Versace]

On 11/27/2012 01:06 PM, Ian Romanick wrote:
> On 11/21/2012 05:43 PM, Chad Versace wrote:
>> Fixes error EGL_BAD_ATTRIBUTE in the tests below on Intel Sandybridge:
>>    * piglit egl-create-context-verify-gl-flavor, testcase OpenGL ES 3.0
>>    * gles3conform, revision 19700, when GL3Tests are ran with -fbo
>>
>> The series lives on my es3-bit-v3 branch. It adds a new enum, __DRI_API_GLES3,
>> and does the needed plumbing in the EGL and DRI layers and the Intel drivers
>> to support EGL_OPENGL_ES3_BIT_KHR. The GLX layer and core mesa are left
>> untouched.
>>
>> I tested the series against gen6 with piglit
>> egl-create-context-verify-gl-flavor. I verified that the series, other than
>> exposing ES3, does not change the set of exposed EGL context flavors.
> 
> Have you tested this on recent GLES3 conform?  Perhaps Matt or someone could try
> that and give a Tested-by.

I tested it against gles3conform at a revision after it had begun using the ES3
bit. Before this series, no tests ranin -fbo mode. After the series, some tests ran and
passed.

> 
>> v2: Only expose the ES3 bit if the hardware/driver combo is capable of
>> creating an ES3 context, as requested by Ian.
> 
> Other than my nits on patch 1, this series is:
> 
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>