[Mesa-dev] [PATCH 2/3] glcpp: Support #elif(expression) with no intervening space.

[Carl Worth]

Matt Turner <mattst88 at gmail.com> writes:
> And add a test case to ensure that this works.
>
> See 17f9beb6 for #if change.

The code here looks fine, (and it's surprising that #if got this
treatment without #elif so long ago).

Your commit message says "add a test case to ensure this works" but the
only test case is in the negative sense, (flagging an invalid identifier
of elif110 after the '#'). I'd like to also see a passing test with
something like:

#if 0
#elif(1)
success
#endif

With that added, I give:

Reviewed-by: Carl Worth <cworth at cworth.org>

to this commit and the preceding commit.

(For the subsequent __LINE__ and __FILE__ I think we can do better, and
I'll attempt that next.)

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121127/575e48d5/attachment.pgp>