[Mesa-dev] [PATCH 2/3] glcpp: Support #elif(expression) with no intervening space.

Carl Worth cworth at cworth.org
Wed Nov 28 21:37:40 PST 2012


Carl Worth <cworth at cworth.org> writes:
> (For the subsequent __LINE__ and __FILE__ I think we can do better, and
> I'll attempt that next.)

I've coded this up, and I think the support is quite reasonable.

After I coded it, I simplified some repeated code a bit, and then I
started exploring some token-pasting code which was inspired by my new
test case.

Ken, you had me convinced that I had forgotten to fix that old "a ## b
## c" token-pasting bug. The truth was that I had forgotten that I had
actually fixed that some time ago. But I did find some other
token-pasting bugs, (pasting the expansion of an internally-defined
macro which expands to an integer was failing).

So expect a series of 7 patches to address these issues in the
preprocessor.

I didn't see any of the piglit tests that I run on a regular basis
changed by the series. (I saw the fs-bool-less-compare-true test flip
From pass to fail, but I'm assuming that's just another unreliable
test.)

Matt, you said you were originally doing this to address some es3conform
tests. Can you test this series on those, please?

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121128/19ef9849/attachment.pgp>


More information about the mesa-dev mailing list