[Mesa-dev] [PATCH] gallium: unify transfer functions

[Andy Furniss]

Marek Olšák wrote:
> Hi,
>
> this is actually a very small cleanup that got unexpectedly big. I
> really underestimated the size of gallium.

Build nit -

make[3]: Entering directory 
`/home/andy/Src/Mesa-git/mesa/src/gallium/auxiliary'
gcc -c -I. -I../../../src/gallium/include 
-I../../../src/gallium/auxiliary -I../../../src/gallium/drivers  -g -O2 
-Wall -std=c99 -Werror=implicit-function-declaration 
-Werror=missing-prototypes -fno-strict-aliasing -fno-builtin-memcmp -g 
-fPIC -D_GNU_SOURCE -DDEBUG -DTEXTURE_FLOAT_ENABLED -DUSE_X86_ASM 
-DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM -DHAVE_DLOPEN 
-DHAVE_POSIX_MEMALIGN -DIN_DRI_DRIVER -DGLX_INDIRECT_RENDERING 
-DGLX_DIRECT_RENDERING -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER 
-DHAVE_ALIAS -DHAVE_LLVM=0x0301 -fvisibility=hidden -I/usr/include 
-D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS 
-D__STDC_LIMIT_MACROS util/u_debug.c -o util/u_debug.o
util/u_debug.c: In function 'debug_dump_transfer_bmp':
util/u_debug.c:626: warning: passing argument 1 of 'pipe_get_tile_rgba' 
from incompatible pointer type
util/u_debug.c:626: warning: passing argument 3 of 'pipe_get_tile_rgba' 
makes integer from pointer without a cast
util/u_debug.c:626: warning: passing argument 7 of 'pipe_get_tile_rgba' 
makes pointer from integer without a cast
util/u_debug.c:626: error: too many arguments to function 
'pipe_get_tile_rgba'