[Mesa-dev] [PATCH 0/8] sRGB fixes
eric at anholt.net
Thu Oct 25 09:10:18 PDT 2012
Adam Jackson <ajax at redhat.com> writes:
> On Wed, 2012-10-24 at 10:08 -0700, Ian Romanick wrote:
>> This series contains a bunch of Mesa and GLX fixes releated to sRGB
>> drawables. It should contain all of the work necessary to allow drivers to
>> advertise sRGB fbconfigs.
>> What is missing is a 9th patch to actually add some sRGB fbconfigs to the
>> Intel driver. I haven't done this yet because I haven't decided the right
>> way. I don't want to have duplicate sRGB and non-sRGB visuals, but if the
>> client-side driver avertises only sRGB and the server-side driver only
>> advertises RGB (or vice-versa), you get no visuals.
> I don't see why that's true. You don't get sRGB rendering until you've
> called glEnable(GL_FRAMEBUFFER_SRGB). Just flag all your fbconfigs as
> sRGB-capable. Older libGL looks like it's smart enough to ignore
> unknown attribs, and current libGL doesn't look at the sRGB attrib in
> fbconfig matching.
> Which I think means that #7 might be wrong? The sRGB-ness of the buffer
> is a property of the enable state, not the visual.
It's a mess, but I think it's a correct mess. The intel driver demotes
SARGB8 to normal ARGB when the enable isn't turned on, and when I tried
to review things before I decided that was the only time that the format
mattered for the window system color buffer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the mesa-dev