[Mesa-dev] [PATCH 0/8] sRGB fixes

Ian Romanick idr at freedesktop.org
Thu Oct 25 11:33:07 PDT 2012

On 10/25/2012 07:37 AM, Adam Jackson wrote:
> On Wed, 2012-10-24 at 10:08 -0700, Ian Romanick wrote:
>> This series contains a bunch of Mesa and GLX fixes releated to sRGB
>> drawables.  It should contain all of the work necessary to allow drivers to
>> advertise sRGB fbconfigs.
>> What is missing is a 9th patch to actually add some sRGB fbconfigs to the
>> Intel driver.  I haven't done this yet because I haven't decided the right
>> way.  I don't want to have duplicate sRGB and non-sRGB visuals, but if the
>> client-side driver avertises only sRGB and the server-side driver only
>> advertises RGB (or vice-versa), you get no visuals.
> I don't see why that's true.  You don't get sRGB rendering until you've
> called glEnable(GL_FRAMEBUFFER_SRGB).  Just flag all your fbconfigs as
> sRGB-capable.  Older libGL looks like it's smart enough to ignore
> unknown attribs, and current libGL doesn't look at the sRGB attrib in
> fbconfig matching.

There's an attribute on the fbconfig that says, "You can enable sRGB 
encoding when rendering to drawables with this config."  We'll only set 
this flag on drawables with RGBA8888 or RGB888.  We won't set it on 
5-6-5 or 10-10-10-2.

By default the sRGB enable is off.  This means that giving an app an 
sRGB fbconfig when they didn't ask for one is okay.  It may, however, 
hide bugs in apps that should have asked for an sRGB fbconfig but didn't.

> Which I think means that #7 might be wrong?  The sRGB-ness of the buffer
> is a property of the enable state, not the visual.
> - ajax

More information about the mesa-dev mailing list