[Mesa-dev] Burninating the old VS backend [v1]

Eric Anholt eric at anholt.net
Fri Oct 26 16:01:10 PDT 2012


Kenneth Graunke <kenneth at whitecape.org> writes:

> This patch series replaces the old brw_vs_emit.c backend with a (much
> smaller) translator from Mesa IR -> brw_vec4 IR, similar to what Eric
> recently did on the FS side.
>
> You can obtain this from the 'vpclean' branch of ~kwg/mesa.
>
> Here's the diffstat:
>  src/mesa/drivers/dri/i965/brw_vs_emit.c          | 1810 ------------------
>  15 files changed, 770 insertions(+), 2189 deletions(-)
>
> This has zero Piglit regressions on Ivybridge, even including Ian's
> uncommitted ARB_vertex_program/ARB_fragment_program generated tests
> (see the arb_program branch of ~idr/piglit).  I still need to run Piglit
> on earlier platforms.
>
> I also tested Quake 4 (ARB_vp) and OpenArena (FF) on Ivybridge.
> Both continue to work fine.  I observed no performance difference in OA.

Other than the comments I provided, patches other than #8 are:

Reviewed-by: Eric Anholt <eric at anholt.net>

If we can't measure performance difference on something like ETQW or
doom3 or q4 at low resolution, I'd be in favor of landing this even with
known codegen quality regressions like with DP4s.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121026/12fa8afc/attachment-0001.pgp>


More information about the mesa-dev mailing list