[Mesa-dev] [PATCH v2 2/2] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

[Jordan Justen]

On Tue, Sep 4, 2012 at 2:16 PM, Chad Versace
<chad.versace at linux.intel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 09/04/2012 12:08 PM, Jordan Justen wrote:
>> Change the format to [MAJOR.MINOR][CORE|COMPAT] For example: 3.0, CORE,
>> COMPAT, 3.2CORE
>>
>> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com> Reviewed-by: Brian
>> Paul <brianp at vmware.com> ---
>>
>> v2: * Remove override_version function * Fix comment on
>> create_version_string header
>>
>> docs/envvars.html       |   11 +++++-- src/mesa/main/context.c |    4 +++
>> src/mesa/main/version.c |   82
>> +++++++++++++++++++++++++++++++++++------------ src/mesa/main/version.h |
>> 3 ++ 4 files changed, 77 insertions(+), 23 deletions(-)
>
> I haven't tested this patch, but it looks broken.
>
> With this patch, _mesa_initialize_context first calls
> _mesa_override_gl_version. Later, the first time eglMakeCurrent is called on
> the context, _mesa_compute_version is called, which overrides the overriding
> done by _mesa_override_gl_version.

_mesa_compute_version checks to see if ctx->Version is non-zero, and
if so, it bails out without computing the version. Since the override
happens early, ctx->Version is already set.

> I think the proper place to call _mesa_override_gl_version is either 1) at the
> old call location of override_version() or, even better, 2) in
> _mesa_compute_version.

_mesa_compute_version is too late, because context init is affected by
the API type.

-Jordan

> - ----
> Chad Versace
> chad.versace at linux.intel.com
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.19 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJQRm+zAAoJEAIvNt057x8idFEP/jvKRwsVHuBdxUOllxyfXZ3f
> kD+B3hYKRFy9PMydk6DtTEmQ5RLMnOAsizMNzsdQB+MBEmaVAB0UW3go5SYxzjkY
> 67H/I1lxLpw5tG14mRSNQIlukWyadaFkutyJ9gj9DmLOJXUaco7a3qfuT83gx4L1
> rvcy/eNmPHKolyC1sAvq2wOQyLcwsTGua74RmzAqlOuq+6t24MiFewIaYhwASkdD
> hcvjRcJWmoyee9mtzSKuhLMIEVCB1l0cG1xP+/4PU2rVt8UdAKL5AAoaHwpRGMO+
> NcGb3Ee/zQEBFYmtGjm105t+PlgoPTKxMvtX0COLg6Odsw8EW4gMc/5NNjz3QhUL
> uwUBznPBmFu7mRFs1jE5nh9p1+0UXKkslEY1N4v6E3sHRIzeL0xkT8Dx6Vi8VRkP
> qu0Pbka1Q2iAplKLkhElO4yf2YqeA5BFRd0euN5Y9Kbhy301Py5/8hQolKmme8tm
> 1j70+y4l+TQlJqWVkcoJt9Yu3GuvrftaHQrw69R14sTxwNfqpptlxziWApk3KInY
> 0J6Za4WUt3BPWMBvwBRQVvE3UMIExRUx0i0GA9a/0XUrW+tecvF17/1puNlhomi6
> 1MG+W2i+JdyiySOKfQr4lZo+3Fc+jORtS/3rzVYytb9wtHz+hECn25U0CIlkRIiS
> Wajwwo11y2FPZVhXZGM4
> =hzNt
> -----END PGP SIGNATURE-----
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev