[Mesa-dev] [PATCH v2 2/2] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/04/2012 03:03 PM, Jordan Justen wrote:
> On Tue, Sep 4, 2012 at 2:16 PM, Chad Versace <chad.versace at linux.intel.com>
> wrote: On 09/04/2012 12:08 PM, Jordan Justen wrote:
>>>> Change the format to [MAJOR.MINOR][CORE|COMPAT] For example: 3.0,
>>>> CORE, COMPAT, 3.2CORE
>>>> 
>>>> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com> Reviewed-by:
>>>> Brian Paul <brianp at vmware.com> ---
>>>> 
>>>> v2: * Remove override_version function * Fix comment on 
>>>> create_version_string header
>>>> 
>>>> docs/envvars.html       |   11 +++++-- src/mesa/main/context.c |    4
>>>> +++ src/mesa/main/version.c |   82 
>>>> +++++++++++++++++++++++++++++++++++------------
>>>> src/mesa/main/version.h | 3 ++ 4 files changed, 77 insertions(+), 23
>>>> deletions(-)
> 
> I haven't tested this patch, but it looks broken.
> 
> With this patch, _mesa_initialize_context first calls 
> _mesa_override_gl_version. Later, the first time eglMakeCurrent is called
> on the context, _mesa_compute_version is called, which overrides the
> overriding done by _mesa_override_gl_version.
> 
>> _mesa_compute_version checks to see if ctx->Version is non-zero, and if
>> so, it bails out without computing the version. Since the override 
>> happens early, ctx->Version is already set.

I'm sorry. I failed to see if `if (ctx->Version) return` with which
_mesa_compute_version begins. This patch has my reviewed-by.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQRoYwAAoJEAIvNt057x8iQVcP/iZ+5pykAgitkYg0s4uFAIOJ
FBm7anRoIKX3VClC7VWcCtjElAy5Bz1heukncJ+kyKx6x76k68nSdPdqYFTZiVpf
d1+CKvz6zpeWRx7+DvImJ0WxOAtYZ/fe2bxbUSZjvcj911R9yhF+TMD5p7YjnR3X
y5QrxKtjm2B5aF3xH86uMSaR0Hg3X6xoO9/BHLrAkhyxaYD3l6QiZvdDaNr+ZgTR
3u8ES3mKCYNmKfFwHvTPuGhLRnMgeYi1JRW/RFc1tpAOFRN+UaDiwittJZRGPGDs
AtN/QWW/tY14NMNY6MfWJIXsZZz0n05EN1K4pTRY0R9mkiKMvC9dzw8pxqfE3PAq
LdTYBt5kjUkmDz+aD3Q3GNb05Xga9IgRqJ9dxQvvnNHgZASssgCGfhGxICc+PCIr
8vq6B6KXGG8EyU+WMCN24WdgCea5YZfuLBjB/zWn/0QCA/P8Cz4kFh8E/ThwXw2q
H/+/6r004tJ9QB0AInGHaTr0ChTG4T80xqGQjjz+dfHhAxGwqw+VHLFilE8HFByF
RZSsb7Stj+rV06xWYZeT2NNMQvJbD4/9hLUijpq1fqp+JWicYXQbvOLOsm2CwxOv
M9onxFuxQiApXQD3Nis4Ro63DFYplyppcc6mCz3pHmxv/p5ErJo6zj/qebFE4x4U
cFmkNTx6xoVr+TGoUnUT
=D70f
-----END PGP SIGNATURE-----