[Mesa-dev] [PATCH 7/9] Remove useless memset after calloc

Brian Paul brianp at vmware.com
Wed Sep 5 07:35:39 PDT 2012


On 09/05/2012 12:42 AM, Matt Turner wrote:
> ---
>   src/glx/dri_glx.c   |    1 -
>   src/glx/drisw_glx.c |    1 -
>   2 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c
> index 3a727e5..03237d4 100644
> --- a/src/glx/dri_glx.c
> +++ b/src/glx/dri_glx.c
> @@ -850,7 +850,6 @@ driCreateScreen(int screen, struct glx_display *priv)
>      if (psc == NULL)
>         return NULL;
>
> -   memset(psc, 0, sizeof *psc);
>      if (!glx_screen_init(&psc->base, screen, priv)) {
>         free(psc);
>         return NULL;
> diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c
> index 920a9ab..014296b 100644
> --- a/src/glx/drisw_glx.c
> +++ b/src/glx/drisw_glx.c
> @@ -636,7 +636,6 @@ driswCreateScreen(int screen, struct glx_display *priv)
>      if (psc == NULL)
>         return NULL;
>
> -   memset(psc, 0, sizeof *psc);
>      if (!glx_screen_init(&psc->base, screen, priv)) {
>         free(psc);
>         return NULL;

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list