[Mesa-dev] [PATCH 2/2] mesa/glsl: rename preprocess to glcpp_preprocess

Kenneth Graunke kenneth at whitecape.org
Thu Sep 13 23:36:57 PDT 2012


On 09/13/2012 05:13 PM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> This symbol with dricore escapes into the namespace, its too generic,
> we should prefix it with something just to be nice.
> 
> Should be applied to stable + 9.0
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>

Forgive me for not understanding how linkers work, but...this symbol
should -not- be exposed at all.  It's completely internal and nobody
except the current callers should ever call it.  If it's getting exposed
that's broken and we need to fix that.  I hate to think what else is
getting exposed.

As I understand it, all of our visibility flags stopped taking effect at
some point during the automake conversion.  We need to figure out why
and how to fix it...IMHO we can't release without fixing that.

Is it not possible?


More information about the mesa-dev mailing list