[Mesa-dev] [PATCH] mesa: make global perm variable static const

Dave Airlie airlied at gmail.com
Fri Sep 14 19:57:24 PDT 2012


this array doesn't look like it needs to be global or unconst.

Signed-off-by: Dave Airlie <airlied at redhat.com>
---
 src/mesa/program/prog_noise.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/program/prog_noise.c b/src/mesa/program/prog_noise.c
index 1713ddb..75cd8c6 100644
--- a/src/mesa/program/prog_noise.c
+++ b/src/mesa/program/prog_noise.c
@@ -76,7 +76,7 @@
  * A vector-valued noise over 3D accesses it 96 times, and a
  * float-valued 4D noise 64 times. We want this to fit in the cache!
  */
-unsigned char perm[512] = { 151, 160, 137, 91, 90, 15,
+static const unsigned char perm[512] = { 151, 160, 137, 91, 90, 15,
    131, 13, 201, 95, 96, 53, 194, 233, 7, 225, 140, 36, 103, 30, 69, 142, 8,
       99, 37, 240, 21, 10, 23,
    190, 6, 148, 247, 120, 234, 75, 0, 26, 197, 62, 94, 252, 219, 203, 117, 35,
-- 
1.7.11.4



More information about the mesa-dev mailing list