[Mesa-dev] [PATCH] Use signbit() in IS_NEGATIVE and DIFFERENT_SIGNS

[Chris Wilson]

On Mon, 17 Sep 2012 16:34:21 -0700, Matt Turner <mattst88 at gmail.com> wrote:
> I understand Ian's concern given the subtle nature of this code.
> Brian's commit (c8a86f717 - converting from macros to inline
> functions) caused bug 54365, and then his fix (23cd6c43da) caused bug
> 54805. Neither commit looked like it should cause any problems.

The cause of the second regression is fairly simple
  (unsigned char)(1<<31) == 0.
The fi_type is also ill-defined where sizeof(GLint) != sizef(float).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre