[Mesa-dev] [PATCH 11/17] i965/vs: move VS-specific data members to vs_vec4_visitor.

[Eric Anholt]

Paul Berry <stereotype441 at gmail.com> writes:

> This patch moves the following data structures from vec4_visitor to
> vec4_vs_visitor, since they contain VS-specific data:
>
> - struct brw_vs_compile *c
> - struct brw_vs_prog_data *prog_data
> - src_reg *vp_temp_regs
> - src_reg vp_addr_reg
>
> Since brw_vs_compile and brw_vs_prog_data also contain vec4-generic
> data, the following pointers are added to the base class, to allow it
> to access the vec4-generic portions of these data structures:
>
> - struct brw_vec4_compile *vec4_compile
> - struct brw_vec4_prog_key *vec4_key
> - struct brw_vec4_prog_data *vec4_prog_data

I would lean toward the base class (which contains most of the members
and usages, I think) having the short name, and the derived class having
the more specific name.  Either way, patch 7-11 are:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130408/d64bd8a9/attachment-0001.pgp>