[Mesa-dev] [PATCH 11/17] i965/vs: move VS-specific data members to vs_vec4_visitor.

[Paul Berry]

On 8 April 2013 09:41, Eric Anholt <eric at anholt.net> wrote:

> Paul Berry <stereotype441 at gmail.com> writes:
>
> > This patch moves the following data structures from vec4_visitor to
> > vec4_vs_visitor, since they contain VS-specific data:
> >
> > - struct brw_vs_compile *c
> > - struct brw_vs_prog_data *prog_data
> > - src_reg *vp_temp_regs
> > - src_reg vp_addr_reg
> >
> > Since brw_vs_compile and brw_vs_prog_data also contain vec4-generic
> > data, the following pointers are added to the base class, to allow it
> > to access the vec4-generic portions of these data structures:
> >
> > - struct brw_vec4_compile *vec4_compile
> > - struct brw_vec4_prog_key *vec4_key
> > - struct brw_vec4_prog_data *vec4_prog_data
>
> I would lean toward the base class (which contains most of the members
> and usages, I think) having the short name, and the derived class having
> the more specific name.


Sure, I can go along with that.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130409/9e79b931/attachment.html>