[Mesa-dev] [PATCH 4/5] i965/fs: Remove incorrect note of writing attr in centroid workaround.

Eric Anholt eric at anholt.net
Wed Apr 10 11:54:41 PDT 2013


This instruction doesn't update its IR destination, it just moves from
payload to f0.  This caused the dead code elimination pass I'm adding to
dead-code-eliminate the first step of interpolation.
---
 src/mesa/drivers/dri/i965/brw_fs.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 331e1ea..3917dba 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -1064,7 +1064,7 @@ fs_visitor::emit_general_interpolation(ir_variable *ir)
                    * unlit, replace the centroid data with non-centroid
                    * data.
                    */
-                  emit(FS_OPCODE_MOV_DISPATCH_TO_FLAGS, attr);
+                  emit(FS_OPCODE_MOV_DISPATCH_TO_FLAGS);
                   fs_inst *inst = emit_linterp(attr, fs_reg(interp),
                                                interpolation_mode, false);
                   inst->predicate = BRW_PREDICATE_NORMAL;
-- 
1.7.10.4



More information about the mesa-dev mailing list