[Mesa-dev] [PATCH 3/5] i965/fs: Add a helper function for checking for partial register updates.

Eric Anholt eric at anholt.net
Wed Apr 10 16:46:41 PDT 2013


Matt Turner <mattst88 at gmail.com> writes:

> On Wed, Apr 10, 2013 at 11:54 AM, Eric Anholt <eric at anholt.net> wrote:
>> These checks were all over, and every time I wrote one I had to try to
>> decide again what the cases were for partial updates.
>> ---
>>  src/mesa/drivers/dri/i965/brw_fs.cpp               |   35 +++++++++++---------
>>  src/mesa/drivers/dri/i965/brw_fs.h                 |    1 +
>>  .../drivers/dri/i965/brw_fs_copy_propagation.cpp   |    4 +--
>>  src/mesa/drivers/dri/i965/brw_fs_cse.cpp           |    3 +-
>>  .../drivers/dri/i965/brw_fs_live_variables.cpp     |    4 +--
>>  5 files changed, 24 insertions(+), 23 deletions(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
>> index c12ba45..331e1ea 100644
>> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
>> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
>> @@ -2662,10 +2670,7 @@ fs_visitor::get_instruction_generating_reg(fs_inst *start,
>>                                            fs_reg reg)
>>  {
>>     if (end == start ||
>> -       end->predicate ||
>> -       end->force_uncompressed ||
>> -       end->force_sechalf ||
>> -       reg.reladdr ||
>
> Is the removal of reg.reladdr intentional?

Oops.  Thanks for paying close attention.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130410/24f64348/attachment-0001.pgp>


More information about the mesa-dev mailing list