[Mesa-dev] [PATCH] mesa: fix type comparison error in sub-texture error checking code

Tapani Pälli tapani.palli at intel.com
Tue Apr 16 23:07:21 PDT 2013


patch fixes a crash that happens if glTexSubImage2D is called with a
negative xoffset.

Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
---
 src/mesa/main/teximage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 784b389..ae053e8 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -1536,7 +1536,7 @@ error_check_subtexture_dimensions(struct gl_context *ctx,
    }
 
    /* check xoffset and width */
-   if (xoffset < -destImage->Border) {
+   if (xoffset < (GLint) -destImage->Border) {
       _mesa_error(ctx, GL_INVALID_VALUE, "%s%dD(xoffset)",
                   function, dims);
       return GL_TRUE;
-- 
1.8.1.4



More information about the mesa-dev mailing list