[Mesa-dev] [PATCH] llvmpipe: Don't support Z32_FLOAT_S8X24_UINT texture sampling support either.

[Brian Paul]

On 04/20/2013 03:45 AM, jfonseca at vmware.com wrote:
> From: José Fonseca<jfonseca at vmware.com>
>
> Because we don't support, and the u_format fallback doesn't work for
> zs formats.
> ---
>   src/gallium/drivers/llvmpipe/lp_screen.c |   10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c
> index 5535f85..667ade1 100644
> --- a/src/gallium/drivers/llvmpipe/lp_screen.c
> +++ b/src/gallium/drivers/llvmpipe/lp_screen.c
> @@ -361,6 +361,12 @@ llvmpipe_is_format_supported( struct pipe_screen *_screen,
>            return FALSE;
>      }
>
> +   /* TODO: Support Z32_FLOAT_S8X24_UINT. See lp_bld_depth.c. */
> +   if (format_desc->colorspace == UTIL_FORMAT_COLORSPACE_ZS&&
> +       format_desc->block.bits>  32) {
> +      return FALSE;
> +   }
> +
>      if (bind&  PIPE_BIND_DEPTH_STENCIL) {
>         if (format_desc->layout != UTIL_FORMAT_LAYOUT_PLAIN)
>            return FALSE;
> @@ -368,10 +374,6 @@ llvmpipe_is_format_supported( struct pipe_screen *_screen,
>         if (format_desc->colorspace != UTIL_FORMAT_COLORSPACE_ZS)
>            return FALSE;
>
> -      /* TODO: Support Z32_FLOAT_S8X24_UINT. See lp_bld_depth.c. */
> -      if (format_desc->block.bits>  32)
> -         return FALSE;
> -
>         /* TODO: Support stencil-only formats */
>         if (format_desc->swizzle[0] == UTIL_FORMAT_SWIZZLE_NONE) {
>            return FALSE;

Reviewed-by: Brian Paul <brianp at vmware.com>