[Mesa-dev] [PATCH] radeonsi: cleanup disabling tiling for UVD

[Christian König]

Am 22.04.2013 09:35, schrieb Michel Dänzer:
> On Sam, 2013-04-20 at 13:21 +0200, Christian König wrote:
>> From: Christian König <christian.koenig at amd.com>
>>
>> Should fix: https://bugs.freedesktop.org/show_bug.cgi?id=63702
>>
>> Signed-off-by: Christian König <christian.koenig at amd.com>
>> ---
>>   src/gallium/drivers/radeonsi/radeonsi_uvd.c |    6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/gallium/drivers/radeonsi/radeonsi_uvd.c b/src/gallium/drivers/radeonsi/radeonsi_uvd.c
>> index d49c088..20d079f 100644
>> --- a/src/gallium/drivers/radeonsi/radeonsi_uvd.c
>> +++ b/src/gallium/drivers/radeonsi/radeonsi_uvd.c
>> @@ -76,6 +76,7 @@ struct pipe_video_buffer *radeonsi_video_buffer_create(struct pipe_context *pipe
>>          template.height = align(tmpl->height / depth, VL_MACROBLOCK_HEIGHT);
>>   
>>          vl_vide_buffer_template(&templ, &template, resource_formats[0], depth, PIPE_USAGE_STATIC, 0);
>> +       templ.flags = R600_RESOURCE_FLAG_TRANSFER;
>>          resources[0] = (struct r600_resource_texture *)
>>                  pipe->screen->resource_create(pipe->screen, &templ);
>>          if (!resources[0])
> Are these resources really used as transfers, i.e. for accessing data
> with the CPU? If not, I think it would be better to add a new
> R600_RESOURCE_* flag instead of (ab)using R600_RESOURCE_FLAG_TRANSFER
> for this.

That's just a temporary workaround till I figure out why tiling with UVD 
on SI doesn't work like it should.

And you're right I should probably document that or cleanup the flag name.

Christian.