[Mesa-dev] [PATCH] i965: Stop passing num_samples to intel_miptree_alloc_hiz().

Eric Anholt eric at anholt.net
Thu Apr 25 13:26:31 PDT 2013


Paul Berry <stereotype441 at gmail.com> writes:

> The number of samples is already available in the miptree data
> structure, so there's no need to pass it in.
>
> I suspect this may fix a subtle bug because in one case
> (intel_renderbuffer_update_wrapper) we were always passing zero for
> num_samples, even though the buffer in question was not guaranteed to
> be single-sampled.  But I wasn't able to find a failing test case.

We probably don't have any texture-multisample tests for depth rendering
or CopyTexSubImage tests with multisample depth.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130425/1a854e93/attachment.pgp>


More information about the mesa-dev mailing list