[Mesa-dev] [PATCH] i965: Stop passing num_samples to intel_miptree_alloc_hiz().

Kenneth Graunke kenneth at whitecape.org
Fri Apr 26 09:26:51 PDT 2013


On 04/25/2013 11:15 AM, Paul Berry wrote:
> The number of samples is already available in the miptree data
> structure, so there's no need to pass it in.
>
> I suspect this may fix a subtle bug because in one case
> (intel_renderbuffer_update_wrapper) we were always passing zero for
> num_samples, even though the buffer in question was not guaranteed to
> be single-sampled.  But I wasn't able to find a failing test case.
> ---
>   src/mesa/drivers/dri/intel/intel_fbo.c         | 4 ++--
>   src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 7 +++----
>   src/mesa/drivers/dri/intel/intel_mipmap_tree.h | 3 +--
>   3 files changed, 6 insertions(+), 8 deletions(-)

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>



More information about the mesa-dev mailing list