[Mesa-dev] [PATCH 1/2] i965/vs: Add a function to fix-up uniform arguments for 3-src insts.

[Kenneth Graunke]

On 04/25/2013 11:51 AM, Matt Turner wrote:
> Three-source instructions have a vertical stride overloaded to 4, which
> prevents directly using vec4 uniforms as arguments. Instead we need to
> insert a MOV instruction to do the replication for the three-source
> instruction.
>
> With this in place, we can use three-source instructions in the vertex
> shader. While some thought needs to go into deciding whether its better
> to use a three-source instruction rather than a sequence of equivalent
> instructions (when one or more sources are uniforms or immediates), this
> will allow us to skip a lot of ugly lowering code and use the BFE and
> BFI2 instructions directly.
> ---
> These patches should go before my ARB_gpu_shader5 series, and allow me to
> drop
>
> [PATCH 07/16] glsl: Add bitfieldInsert-to-bfm/bitops lowering pass.
> [PATCH 08/16] glsl: Add BFE-to-bitops lowering pass.

Both are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>