[Mesa-dev] [PATCH] Remove TargetOptions.RealignStack for llvm>=3.4

Tom Stellard tom at stellard.net
Tue Aug 6 15:35:24 PDT 2013


On Wed, Aug 07, 2013 at 12:05:25AM +0200, Laurent Carlier wrote:
> Since llvm -3.4svn r187618, TargetOptions doesn't provide
> anymore RealignStack, so only enable it with llvm<3.4

Thanks, I've committed this patch.

To the llvmpipe developers:  You must now specify the RealignStack option
using function attributes, see LLVM commit r187618.  Also, if possible,
it would be nice if you could use the LLVM C API for function
attributes, since this will help reduce the chances for build breakages
in the future.

Thanks,
Tom

> ---
>  src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
> index e09bb78..e8d2db2 100644
> --- a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
> +++ b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
> @@ -273,8 +273,10 @@ lp_build_create_jit_compiler_for_module(LLVMExecutionEngineRef *OutJIT,
>     TargetOptions options;
>  #if defined(PIPE_ARCH_X86)
>     options.StackAlignmentOverride = 4;
> +#if HAVE_LLVM < 0x0304
>     options.RealignStack = true;
>  #endif
> +#endif
>  
>  #if defined(DEBUG)
>     options.JITEmitDebugInfo = true;
> -- 
> 1.8.3.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list