[Mesa-dev] [PATCH] Remove TargetOptions.RealignStack for llvm>=3.4

Roland Scheidegger sroland at vmware.com
Tue Aug 6 16:57:09 PDT 2013


Am 07.08.2013 00:35, schrieb Tom Stellard:
> On Wed, Aug 07, 2013 at 12:05:25AM +0200, Laurent Carlier wrote:
>> Since llvm -3.4svn r187618, TargetOptions doesn't provide
>> anymore RealignStack, so only enable it with llvm<3.4
> 
> Thanks, I've committed this patch.
> 
> To the llvmpipe developers:  You must now specify the RealignStack option
> using function attributes, see LLVM commit r187618.  Also, if possible,
> it would be nice if you could use the LLVM C API for function
> attributes, since this will help reduce the chances for build breakages
> in the future.

Sounds like a good idea. However I believe the only reason we used non-c
api was because the things we were using it for just weren't possible
with it. Though I guess if they now are we should probably use it but
we'd still need to keep the old code for working with older versions.

Roland


More information about the mesa-dev mailing list