[Mesa-dev] [PATCH] dri: Choose a decent global driNConfigOptions.

[Eric Anholt]

Ian Romanick <idr at freedesktop.org> writes:

> On 08/08/2013 03:59 AM, Eric Anholt wrote:
>> Previously, we were asserting that each driver specified an NConfigOptions
>> exactly equal to the number of options they supplied, leading to frequent
>> bugs when people would forget to adjust the value when adjusting driver
>> options.  Instead, just overallocate the table by a bit and leave sanity
>> checking to the assert in findOption().
>
> This makes sense.  I thought part of the reason for __driNConfigOptions 
> being exact was that it was used by external driconf GUI tools.  Will 
> this change break those tools?

I spent an embarassingly long time trying to find how the external tool
used the config symbols, only to find out that it doesn't.  driconf
calls out to xdriinfo, which does a
glXGetProcAddress("glXGetDriverConfig"), and parses the XML returned
From calling the returned function.  It's like a sane interface! (except
for not checking for an extension string trying all this)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130808/50e53dc4/attachment.pgp>