[Mesa-dev] [PATCH] dri: Choose a decent global driNConfigOptions.

Kenneth Graunke kenneth at whitecape.org
Thu Aug 8 14:16:42 PDT 2013


On 08/08/2013 03:59 AM, Eric Anholt wrote:
> Previously, we were asserting that each driver specified an NConfigOptions
> exactly equal to the number of options they supplied, leading to frequent
> bugs when people would forget to adjust the value when adjusting driver
> options.  Instead, just overallocate the table by a bit and leave sanity
> checking to the assert in findOption().

Looks reasonable to me.  It'll be nice to not have to change this all 
the time.  I didn't verify that the assertions you mention actually 
catch things, though.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list