[Mesa-dev] [PATCH 3/3] glsl/ast: Don't perform GS input array checks on non-inputs.

Paul Berry stereotype441 at gmail.com
Mon Aug 12 07:14:08 PDT 2013


Previously, we were accidentally calling
handle_geometry_shader_input_decl() on non-input interface block
declarations, resulting in bogus error checking.
---
 src/glsl/ast_to_hir.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 2e97f3b..1b8aca2 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -4567,7 +4567,7 @@ ast_interface_block::hir(exec_list *instructions,
       }
 
       var->interface_type = block_type;
-      if (state->target == geometry_shader)
+      if (state->target == geometry_shader && var_mode == ir_var_shader_in)
          handle_geometry_shader_input_decl(state, loc, var);
       state->symbols->add_variable(var);
       instructions->push_tail(var);
-- 
1.8.3.4



More information about the mesa-dev mailing list