[Mesa-dev] [PATCH 1/2] gallivm: (trivial) fix linear aos sampling of 3d compressed formats

[Jose Fonseca]

Great catch!

Jose

----- Original Message -----
> From: Roland Scheidegger <sroland at vmware.com>
> 
> block size depth is always 1 even for compressed formats (unless someone
> invents true 3d compressed formats at least which we can't represent).
> Nearest (and soa) path had it right.
> ---
>  src/gallium/auxiliary/gallivm/lp_bld_sample_aos.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_sample_aos.c
> b/src/gallium/auxiliary/gallivm/lp_bld_sample_aos.c
> index 2573cec..b9227b5 100644
> --- a/src/gallium/auxiliary/gallivm/lp_bld_sample_aos.c
> +++ b/src/gallium/auxiliary/gallivm/lp_bld_sample_aos.c
> @@ -1141,7 +1141,7 @@ lp_build_sample_image_linear(struct
> lp_build_sample_context *bld,
>  
>     if (dims >= 3) {
>        lp_build_sample_wrap_linear_int(bld,
> -                                      bld->format_desc->block.height,
> +                                      1, /* block length (depth) */
>                                        r_ipart, &r_fpart, r_float,
>                                        depth_vec, z_stride, offsets[2],
>                                        bld->static_texture_state->pot_depth,
> @@ -1233,7 +1233,7 @@ lp_build_sample_image_linear_afloat(struct
> lp_build_sample_context *bld,
>  
>        if (dims >= 3) {
>           lp_build_sample_wrap_linear_float(bld,
> -                                           bld->format_desc->block.height,
> +                                           1, /* block length (depth) */
>                                             r, depth_vec, offsets[2],
>                                             bld->static_texture_state->pot_depth,
>                                             bld->static_sampler_state->wrap_r,
> --
> 1.7.9.5
>