[Mesa-dev] [PATCH 3/4] i965/vs: Move base_reg_count computation to brw_alloc_reg_set().

[Kenneth Graunke]

On 08/22/2013 06:19 PM, Paul Berry wrote:
> On 21 August 2013 23:26, Kenneth Graunke <kenneth at whitecape.org
> <mailto:kenneth at whitecape.org>> wrote:
>
>     We're soon going to be calling brw_alloc_reg_set() from outside of the
>     visitor, where we don't have the precomputed "max_grf" variable handy.
>
>     Signed-off-by: Kenneth Graunke <kenneth at whitecape.org
>     <mailto:kenneth at whitecape.org>>
>     Cc: Paul Berry <stereotype441 at gmail.com
>     <mailto:stereotype441 at gmail.com>>
>
>
> Thanks for doing this, Ken!  Series is:
>
> Reviewed-by: Paul Berry <stereotype441 at gmail.com
> <mailto:stereotype441 at gmail.com>>
>
> Possible follow-up idea: maybe we should move max_grf out of fs_visitor
> and vec4_visitor, and instead put it into brw and initialize it in
> brwCreateContext(), like we do for brw->max_wm_threads etc.

Yeah...we could.  But really, we should just get rid of the ridiculous 
hack range and go back to using BRW_MAX_GRF everywhere.

--Ken